Rework evaluation export #127

provinzio · 2022-05-04T19:14:03Z

The tax evaluation and export is currently under major rework. Most of the tax evaluation is done, but could require some more explanatory comments. The export is basically done, but I am still improving the formatting etc.

I'd love to have a helping hand, reviewing the changes, pinpointing code which could be better and so on....
If you have the time, I'd really appreciate it!

@Griffsano @scientes @jhoogstraat

check draft of BMF against the PR https://www.bundesfinanzministerium.de/Content/DE/Downloads/BMF_Schreiben/Steuerarten/Einkommensteuer/2021-06-17-est-kryptowaehrungen.pdf?__blob=publicationFile&v=2
check that utc times are correctly exported (from import to export)
change timezone for export according to config timezone; update labels of ReportEntries
add deposit/withdrawal of fiat to export excel
taxable_gain looks wrong for sell after 1 year
add export sheet with all buys in tax year (information only)
check against
https://www.youtube.com/watch?v=qV5nfFddCZU&t=1050s

Related #104

normal sum would return Union[decimal.Decimal, Literal[0]] which is unwanted

…rations.list TODO sell.fees and buy.fees are currently not, but should be, considered for tax calculation

…it/withdrawal matching fails (6ea275f)

@Griffsano

credits to @Griffsano

@Griffsano

credits to @Griffsano

@Griffsano

credits to @Griffsano

@Griffsano

credits to @Griffsano

@Griffsano

credits to @Griffsano

- RENAME class methods - UPDATE comments - REFACTOR code - CHANGE Keep track of home fiat balance

…constant

prices from csv are only calculated for exactly one buy/sell pair. merging operations makes sure, that there is only one buy/sell pair

this commit will be removed as soon as i get back to work

jhoogstraat · 2022-05-14T15:25:19Z

I don't know why this is throwing just now, but it does:

CoinTaxman/src/book.py

Line 334 in f076d8e

eur_subtotal = misc.force_decimal(_eur_subtotal)

_eur_subtotal, _eur_total and _eur_fee are None when the operation is a withdrawal (and potentially deposit and others).
Here is an example from my coinbase statement:
2021-01-01T00:00:00Z,Send,EOS,1,EUR,3,"","","","Sent 1,0000 EOS to binancecleos"

jhoogstraat · 2022-05-14T16:02:46Z

I am also getting many Unable to correctly determine buy cost of bought coins... warnings with my binance statement. I have to look into that.

Co-authored-by: Joshua Hoogstraat <[email protected]>

provinzio · 2022-05-14T17:12:47Z

I am also getting many Unable to correctly determine buy cost of bought coins... warnings with my binance statement. I have to look into that.

Buys and sells always come in a pair (a trade). To determine the buy cost of bought coins, it is necessary to know the "sell"-part of the trade: the sell value is the buying cost of these coins. This is important because (1) the bought coins value might be differ from the sell value and (2) the tax calculation requires you to use the real buying costs for tax calculation (see BMF draft)

Example why is is important:

I buy a coin for 1 €, but the coin is at the same time worth 100 €. I just got lucky
Now I am selling my coin for 100 €, which it is worth.

You can see, that I gained 99 €. This calculation is only possible, when Buy and Sell pairs got "matched" and the real buying cost of the coin (1 €) is used for tax calculation (100 € (buy value of the sell-trade) - 1 € (sell value of the buy-trade) = 99 €). If Cointaxman can not match the Buy/sell pairs it only sees

Sell 1 € (worth 1 €)
Buy 1 Coin (worth 100 €)
Sell 1 Coin (worth 100 €)
Buy 100 € (worth 100 €)

Stupid calculation of the gain calculates 100 € - 100 € = 0 € gain. This is what Cointaxman is currently doing for you, hence the warning. It does not realized which Buys and Sells form a trade-pair.

Now, how can we fix this? The matching is done in book.py:resolve_trades. Currently all operations are grouped by time. If at one time only a buy and sell trade exist: they belong together, chaka! If more than two operations were found, CoinTaxman does nothing, bad.... leading to your warning in the end.

To solve this. We have to extend the functionality of resolve_trades so that it's able to match your trade-pairs together. This is where you come into play. Please check your account statements and see which trades (operations happend at the same time) could'nt been matched. Why weren't they matched and what could we do to match them?

provinzio · 2022-05-14T17:14:18Z

I don't know why this is throwing just now, but it does:

CoinTaxman/src/book.py

Line 334 in f076d8e

eur_subtotal = misc.force_decimal(_eur_subtotal)

_eur_subtotal, _eur_total and _eur_fee are None when the operation is a withdrawal (and potentially deposit and others). Here is an example from my coinbase statement: 2021-01-01T00:00:00Z,Send,EOS,1,EUR,3,"","","","Sent 1,0000 EOS to binancecleos"

fixed as part of #130, already merged into the branch

…herit UnrealizedSellReportEntry from SellReportEntry

…ework-evaluation-export

…raise warning.

…writing

… config

provinzio and others added 30 commits April 8, 2022 16:28

CHANGE save list of rows for each operation

51fca76

UPDATE misc.group_by to also accept list[str]

a6ccf11

ADD dsum which sums decimals and returns decimal

b39b77b

normal sum would return Union[decimal.Decimal, Literal[0]] which is unwanted

CHANGE merge identical operations together

abeca6a

UPDATE book: ignore operations with change=0

a16c6df

CHANGE match fees with buy/sell operations, remove fees from book.ope…

86a1390

…rations.list TODO sell.fees and buy.fees are currently not, but should be, considered for tax calculation

FIX typo invsted

71f5c0d

FIX typo mereged

e872a05

UPDATE Extend information in error message when kraken internal depos…

89f9412

…it/withdrawal matching fails (6ea275f)

UPDATE Make taxman helper functions static

d19c35e

UPDATE comment in tax evaluation

581fb9f

ADD config error when country is not implemented

41c0ee3

credits to @Griffsano

UPDATE is_fiat docstring

3721933

credits to @Griffsano

RENAME TaxEvent.sell_price to sell_value

e76ffe9

credits to @Griffsano

ADD platform to export and specify date column header

3aaf6f8

credits to @Griffsano

CHANGE do not upper config.FIAT value in bitpanda import

75f527d

credits to @Griffsano

ADD make drun. Shortcut for development (format lint run)

9cc3c6c

REFACTOR BalanceQueue

d456c50

- RENAME class methods - UPDATE comments - REFACTOR code - CHANGE Keep track of home fiat balance

MOVE taxman staticmethods outside the class, convert tax_deadline to …

d238d8e

…constant

fixup REFACTOR BalanceQueue

ed8f705

REFACTOR rename module import transaction to tr

9bba7b9

CHANGE Binance operation "Launchpool Interest" to CoinLendInterest

6d9d70c

UPDATE error message when operation type was not found

484b47e

ADD docstring to Staking operations

7b8132c

UPDATE Add warning when buffer fee is used, shouldn't happen

c7ad990

FIX merge identical operations before getting prices from csv

7f8fa37

prices from csv are only calculated for exactly one buy/sell pair. merging operations makes sure, that there is only one buy/sell pair

WORK IN PROGRESS

539fd5b

this commit will be removed as soon as i get back to work

ADD basic transfer matching algorithm

7426249

Cleanup

2b9cabd

Include foreign fiat currencies

00acedd

provinzio and others added 4 commits May 14, 2022 18:19

FIX typos

4c76bbc

Co-authored-by: Joshua Hoogstraat <[email protected]>

Merge remote-tracking branch 'origin/main' into rework-evaluation-export

1ff4150

UPDATE sorting of binance operations

93f5280

RM TODO regarding increase of speculation period (#57)

12afc57

provinzio mentioned this pull request May 14, 2022

How to handle deposits from unknown sources? #130

Open

provinzio added 16 commits May 14, 2022 19:19

FIX make archive: check xlsx files instead of csv

c3496ff

RM Buy from export file for now.. added TODO to add trades instead

5f08e55

UPDATE increase width of taxation_type column in export

7bcbfcf

UPDATE no fees in UnrealizedSellReportEntry, better labels; do not in…

6ea53af

…herit UnrealizedSellReportEntry from SellReportEntry

FIX valign in export

b536e41

ADD unrealized sell information to summary page

ce56914

CHANGE Add more information to general page in export

e46c2fb

Merge branch '130-how-to-handle-deposits-from-unknown-sources' into r…

e9ac806

…ework-evaluation-export

CHANGE Remarks of deposits/withdrawals changed, when link is missing

f42b0f9

CHANGE Adjust warning message when missing linked deposits get sold

0984393

FIX Ignore error when not enough EUR in queue to pay fees

3778a53

FIX Catch error when determining sell value of unrealized sell. Only …

9b54ee2

…raise warning.

CHANGE Ignore unrealized sell value in export when it's faulty

d5d58cd

UPDATE Ignore buffer fee warning for config.FIAT

3d6c770

CHANGE Section "Taxation in Germany". updated according to new "BMF" …

76c04b1

…writing

MV calculation of is_taxable to _evaluate_sell

3dba427

provinzio marked this pull request as ready for review May 14, 2022 22:05

provinzio added 2 commits May 15, 2022 00:11

RM unused excel helper functions

b03af45

UPDATE make sure that module tzdata is installed by importing it in…

bb2dcfe

… config

provinzio merged commit f1ea6a1 into main May 14, 2022

provinzio deleted the rework-evaluation-export branch May 14, 2022 22:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rework evaluation export #127

Rework evaluation export #127

provinzio commented May 4, 2022 •

edited

Loading

jhoogstraat commented May 14, 2022 •

edited

Loading

jhoogstraat commented May 14, 2022

provinzio commented May 14, 2022

provinzio commented May 14, 2022

Rework evaluation export #127

Rework evaluation export #127

Conversation

provinzio commented May 4, 2022 • edited Loading

jhoogstraat commented May 14, 2022 • edited Loading

jhoogstraat commented May 14, 2022

provinzio commented May 14, 2022

provinzio commented May 14, 2022

provinzio commented May 4, 2022 •

edited

Loading

jhoogstraat commented May 14, 2022 •

edited

Loading